Jump to content

AJCrowley

Member
  • Posts

    6
  • Joined

  • Last visited

Posts posted by AJCrowley

  1. Ok @deanishe, I've done it the right way.

     

    Added in support for BTC through add/remove as with other currencies, and can also set BTC as the base.

     

    I've forked the original author's repo and submitted a pull request. If there's anything else I should do to keep everything proper, I'd appreciate the advice!


    In the meantime, you can check it out here: https://github.com/AJCrowley/alfred3-workflow-CurrencyConvert

     

    Thanks!

  2. 26 minutes ago, deanishe said:

     

    The proper and polite thing to do (for a project that hasn't been abandoned) would be to fork the workflow on GitHub (here's the link from the OP) and then submit a pull request with your changes there.

     

    Thanks, I did consider submitting a PR, but I don't know if the original dev would want this admittedly somewhat scrappy code in their lovely project. I wouldn't feel right submitting a PR without properly integrating it with the add/remove functionality, and for now, it's just hacked in there.


    If they do, they're free to use it.

     

    If I get around to developing a more elegant solution, I'll definitely fork/PR.

  3. Not sure of the etiquette here, but I've modified this workflow to handle Bitcoin as well.

     

    It's my first time ever writing Ruby, or for Alfred, so please bear with me if I'm not following best practices, and Jin5354 - if you wish to incorporate any of this into your existing code base (or improve upon it), by all means please feel free.

     

    The only files that have been altered are BTC.png has been added to the flags directory, and convert.rb has been modified. However, rather than posting only those files and expecting people to take it apart and put it back together, I'll just post the modded workflow. It seems the board won't accept this file type as an attachment, so I just threw it on a file hosting service: https://nofile.io/f/2Orgj7NKZ7z/Currency.Convert.v1.4.btcmod.alfredworkflow

     

    I hope that someone finds this useful, and if for any reason this is against etiquette or the rules, by all means let me know and I'll take it down.


    Cheers!

  4. Running High Sierra 10.13.1 (17B35a)


    Alfred 3.5 [876]

     

    Lately, Alfred has become extremely slow and laggy. I bring up Alfred, and after each keypress have to wait a second or two before the next keypress registers. It's bordering on unusable. I try to think back to when I first noticed the slowdown, and I'm guessing it was around the time I updated to High Sierra, but I don't know if it's connected.

     

    I found a similar thread about Alfred 2, and have tried all of the suggested steps - I have disabled the eject commands, disabled all workflows, rebuilt the metadata, and disabled all but the most useful features to me. It continues to run at a snail's pace.

     

    Has anyone else been experiencing this problem? Is there anything else that I can try to speed things up? Is there any more useful info that I can provide you to help get to the bottom of this?


    Thanks!

×
×
  • Create New...